dspo commented on code in PR #837:
URL: https://github.com/apache/apisix-helm-chart/pull/837#discussion_r2175027387


##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -216,78 +40,65 @@ podDisruptionBudget:
   # -- Set the maxUnavailable of podDisruptionBudget
   maxUnavailable: 1
 
-podSecurityContext: {}
-  # fsGroup: 2000
-
-securityContext: {}
-  # capabilities:
-  #   drop:
-  #   - ALL
-  # readOnlyRootFilesystem: true
-  # runAsNonRoot: true
-  # runAsUser: 1000
-gateway:
-  # -- Apache APISIX service type for user access itself
-  type: NodePort
-  externalTrafficPolicy: Cluster
-  # annotations:
-  #   service.beta.kubernetes.io/aws-load-balancer-type: nlb
-  # loadBalancerIP: a.b.c.d
-  # loadBalancerSourceRanges:
-  #   - "143.231.0.0/16"
-  # -- load balancer ips
-  externalIPs: []
-  nginx:
-    # -- Nginx workerRlimitNoFile
-    workerRlimitNofile: "20480"
-    # -- Nginx worker connections
-    workerConnections: "10620"
-    # -- Nginx worker processes
-    workerProcesses: auto
-    # -- Nginx error logs path
-    errorLog: stderr
-    # -- Nginx error logs level
-    errorLogLevel: warn
-    # -- Custom configuration snippet.
-    configurationSnippet:
-      main: |
-
-      httpStart: |
-
-      httpEnd: |
+autoscaling:
+  enabled: false
+  minReplicas: 1
 
-      httpSrv: |
+replicaCount: 1

Review Comment:
   fixed



##########
charts/apisix-ingress-controller/values.yaml:
##########
@@ -216,78 +40,65 @@ podDisruptionBudget:
   # -- Set the maxUnavailable of podDisruptionBudget
   maxUnavailable: 1
 
-podSecurityContext: {}
-  # fsGroup: 2000
-
-securityContext: {}
-  # capabilities:
-  #   drop:
-  #   - ALL
-  # readOnlyRootFilesystem: true
-  # runAsNonRoot: true
-  # runAsUser: 1000
-gateway:
-  # -- Apache APISIX service type for user access itself
-  type: NodePort
-  externalTrafficPolicy: Cluster
-  # annotations:
-  #   service.beta.kubernetes.io/aws-load-balancer-type: nlb
-  # loadBalancerIP: a.b.c.d
-  # loadBalancerSourceRanges:
-  #   - "143.231.0.0/16"
-  # -- load balancer ips
-  externalIPs: []
-  nginx:
-    # -- Nginx workerRlimitNoFile
-    workerRlimitNofile: "20480"
-    # -- Nginx worker connections
-    workerConnections: "10620"
-    # -- Nginx worker processes
-    workerProcesses: auto
-    # -- Nginx error logs path
-    errorLog: stderr
-    # -- Nginx error logs level
-    errorLogLevel: warn
-    # -- Custom configuration snippet.
-    configurationSnippet:
-      main: |
-
-      httpStart: |
-
-      httpEnd: |
+autoscaling:
+  enabled: false
+  minReplicas: 1
 
-      httpSrv: |
+replicaCount: 1
 
-      httpAdmin: |
+deployment:
+  # -- Add annotations to Apache APISIX ingress controller resource
+  annotations: []

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to