Copilot commented on code in PR #2451:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2451#discussion_r2184197127
##########
internal/provider/adc/translator/httproute.go:
##########
@@ -295,6 +295,10 @@ func (t *Translator) translateEndpointSlice(portName
*string, weight int, endpoi
}
for _, endpoint := range endpointSlice.Endpoints {
for _, addr := range endpoint.Addresses {
+ if endpoint.Conditions.Terminating !=
nil && *endpoint.Conditions.Terminating {
+ log.Debugw("skip terminating
endpoint", zap.Any("endpoint", endpoint))
Review Comment:
[nitpick] Enhance the debug log with more context (e.g., port name or
backend reference) to make it easier to trace which endpoint was skipped.
```suggestion
log.Debugw("skip terminating
endpoint",
zap.Any("endpoint",
endpoint),
zap.String("portName",
func() string {
if portName !=
nil {
return
*portName
}
return "nil"
}()),
zap.Any("endpointSlice", endpointSlice))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
