ronething commented on code in PR #2451:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2451#discussion_r2184467656
##########
internal/provider/adc/translator/httproute.go:
##########
@@ -283,7 +283,7 @@ func (t *Translator) fillHTTPRoutePolicies(routes
[]*adctypes.Route, policies []
}
}
-func (t *Translator) translateEndpointSlice(portName *string, weight int,
endpointSlices []discoveryv1.EndpointSlice) adctypes.UpstreamNodes {
+func (t *Translator) translateEndpointSlice(portName *string, weight int,
endpointSlices []discoveryv1.EndpointSlice, endpointFilter
func(*discoveryv1.Endpoint) bool) adctypes.UpstreamNodes {
Review Comment:
There is still a need for more clarification. It may not be appropriate to
make adjustments in this PR, as it involves more code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
