dspo commented on code in PR #2451:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2451#discussion_r2184227539
##########
internal/provider/adc/translator/httproute.go:
##########
@@ -295,6 +295,14 @@ func (t *Translator) translateEndpointSlice(portName
*string, weight int, endpoi
}
for _, endpoint := range endpointSlice.Endpoints {
for _, addr := range endpoint.Addresses {
+ if endpoint.Conditions.Ready != nil &&
!*endpoint.Conditions.Ready {
+ log.Debugw("skip not ready
endpoint", zap.Any("endpoint", endpoint))
+ continue
+ }
+ if endpoint.Conditions.Terminating !=
nil && *endpoint.Conditions.Terminating {
+ log.Debugw("skip terminating
endpoint", zap.Any("endpoint", endpoint))
+ continue
+ }
Review Comment:
It is recommended to put the filter in the controller layer and not manage
the status of k8s resources in the translation layer.
https://github.com/apache/apisix-ingress-controller/blob/master/internal/controller/utils.go#L1447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
