Baoyuantop commented on PR #12968: URL: https://github.com/apache/apisix/pull/12968#issuecomment-4241127200
The current PR bypasses `checker:get_target_status()` to directly read the SHM, but it hardcodes the internal key format of `lua-resty-healthcheck`. This is very fragile and may break after `resty.healthcheck` is upgraded. I have documented the original issue described in this PR at https://github.com/apache/apisix/issues/13101, and I will follow up on it in this issue later. I'll close this PR for now and we can reopen it if needed later. Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
