>From Ali Alsuliman <[email protected]>:

Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 )

Change subject: [NO ISSUE][OTH] Add an identifier mapper to map identifiers
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/Warning.java@98
PS2, Line 98:         if (params == null) {
> why is params ever null?
This is similar to our exceptions where the params are null if the exception 
does not use parameters in its message.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: cheshire-cat
Gerrit-Change-Id: I4bd0a602fddeb09a7dfca64ce35f5eee6f3c4777
Gerrit-Change-Number: 9884
Gerrit-PatchSet: 3
Gerrit-Owner: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Michael Blow <[email protected]>
Gerrit-Comment-Date: Mon, 29 Mar 2021 20:16:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Blow <[email protected]>
Gerrit-MessageType: comment

Reply via email to