>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 )
Change subject: [NO ISSUE][OTH] Add an identifier mapper to map identifiers ...................................................................... Patch Set 5: Code-Review+2 (7 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AbstractLangTranslator.java@228 PS5, Line 228: dataset the day the upper case message died https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java@436 PS5, Line 436: dataset ok, thank goodness they died in some places #facepalm https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java@467 PS5, Line 467: dataset() the loss of plurality is kinda sad here- we could at least make this + dataset() + "(s) in these cases https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java@479 PS5, Line 479: "Returning not allowed on " + dataset() + " with meta records"); same^ https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java@591 PS5, Line 591: + " is not supported on " + dataset() + " with meta records"); same ^ https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetRewriter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetRewriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/function/DatasetRewriter.java@72 PS5, Line 72: " + dataset()) loss of plurality has created bad grammar here as well- consider (s), or a plural parameter to the identifier method https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataNode.java@692 PS5, Line 692: + "(s)", his eyes uncovered! -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I4bd0a602fddeb09a7dfca64ce35f5eee6f3c4777 Gerrit-Change-Number: 9884 Gerrit-PatchSet: 5 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Comment-Date: Wed, 31 Mar 2021 18:23:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
