>From Michael Blow <[email protected]>: Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 )
Change subject: [NO ISSUE][OTH] Add an identifier mapper to map identifiers ...................................................................... Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/3/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/IdentifierUtil.java File hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/IdentifierUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/3/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/IdentifierUtil.java@26 PS3, Line 26: is dataset really used in Algebricks, or is it more of a hyracks concept? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884/3/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/utils/IdentifierUtil.java@30 PS3, Line 30: Dataverse is an *DB construct- seems like we shouldn't infect Hyracks -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/9884 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: cheshire-cat Gerrit-Change-Id: I4bd0a602fddeb09a7dfca64ce35f5eee6f3c4777 Gerrit-Change-Number: 9884 Gerrit-PatchSet: 3 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 30 Mar 2021 01:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
