>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Ali Alsuliman.
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494 )

Change subject: [ASTERIXDB-3509][EXT]: Raise warning for COPY TO CSV schema 
mismatch
......................................................................


Patch Set 9:

(3 comments)

Patchset:

PS9:
check approval


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/98fecbca_acd58a59
PS8, Line 5914: validateCSVSchema
This is all moved to CSVUtils.validateSchema


File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/csv/ACSVRecordPrinter.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/8abfdab9_a80b1253
PS8, Line 123: if (actualFieldNamePointables.size() != 
expectedFieldNames.size()) {
             :             warnMismatchType("Record's schema is different from 
the expected schema");
             :             return false;
             :         }
Should we print both schemas fully?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I38816d549fe5e2feab8f25e8570b8efa486f442c
Gerrit-Change-Number: 19494
Gerrit-PatchSet: 9
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Comment-Date: Thu, 13 Mar 2025 13:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to