>From Hussain Towaileb <[email protected]>: Attention is currently required from: Ali Alsuliman. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494 )
Change subject: [ASTERIXDB-3509][EXT]: Raise warning for COPY TO CSV schema mismatch ...................................................................... Patch Set 12: (5 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AStringPrinterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/5b8da68a_d8e6bee0 PS11, Line 62: getCharOrDefault > This could be placed in CSVUtils and re-used. Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/CSVUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/be2d351b_4d3c4316 PS11, Line 85: (itemTypeProvided ? "\n" : "") > "\n" could be replaced with DEFAULT_RECORD_DELIMITER. […] Done. I have a TODO to figure out what the "" part https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/368c3d9c_3bbd4fbe PS11, Line 88: List > I thought this would be a set (EnumSet. […] Done File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/csv/ACSVRecordPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/838b5912_d4a52ea5 PS11, Line 119: final List<String> expectedFieldNames = Arrays.asList(schema.getFieldNames()); > We could create these two only once up in the constructor. Good catch, done. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/571e53d5_70ef5571 PS11, Line 124: warnMismatchType("Record's schema is different from the expected schema"); > Can we include the sizes of each in the warning? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I38816d549fe5e2feab8f25e8570b8efa486f442c Gerrit-Change-Number: 19494 Gerrit-PatchSet: 12 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Fri, 14 Mar 2025 17:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
