>From Ali Alsuliman <[email protected]>: Attention is currently required from: Hussain Towaileb. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494 )
Change subject: [ASTERIXDB-3509][EXT]: Raise warning for COPY TO CSV schema mismatch ...................................................................... Patch Set 11: (5 comments) File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AStringPrinterFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/6ee0c85b_826dd614 PS11, Line 62: getCharOrDefault This could be placed in CSVUtils and re-used. File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/CSVUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/a7c4e3cc_58333ee8 PS11, Line 85: (itemTypeProvided ? "\n" : "") "\n" could be replaced with DEFAULT_RECORD_DELIMITER. I didn't get the "" part. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/32698f13_f882594c PS11, Line 88: List I thought this would be a set (EnumSet.of()) File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/pointables/printer/csv/ACSVRecordPrinter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/60a1e361_fc5bfb65 PS11, Line 119: final List<String> expectedFieldNames = Arrays.asList(schema.getFieldNames()); We could create these two only once up in the constructor. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494/comment/32988f22_1bfd9df7 PS11, Line 124: warnMismatchType("Record's schema is different from the expected schema"); Can we include the sizes of each in the warning? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19494 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I38816d549fe5e2feab8f25e8570b8efa486f442c Gerrit-Change-Number: 19494 Gerrit-PatchSet: 11 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 14 Mar 2025 09:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
