>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 )
Change subject: [ASTERIXDB-3581][EXT]: Do not retry GCS SDK requests if thread is interrupted ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: We should also undo the offloading of IO to another thread as was done to workaround the issue in Ionic. I would add a cancellation test suite which runs the GCS cloud tests w/ the cancellation we do for non-cloud tests. This should reproduce this problem on Jenkins. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/gcs/GCSConstants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/42d30daf_25ce4ed4 PS1, Line 83: if (Thread.currentThread().isInterrupted()) { : return false; : } The root issue here is if the exception is an interrupt, not if the thread is interrupted. this needs to check `prevThrowable` for instance of InterruptedException. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/9a0a2f02_88e9f56d PS1, Line 99: if (Thread.currentThread().isInterrupted()) { : return false; : } The root issue here is if the exception is an interrupt, not if the thread is interrupted. this needs to check `prevThrowable` for instance of InterruptedException. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I5deb956bda11ee2ca41a1c05616788b2d697622f Gerrit-Change-Number: 19525 Gerrit-PatchSet: 1 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 17 Mar 2025 12:24:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
