>From Hussain Towaileb <[email protected]>: Attention is currently required from: Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 )
Change subject: [ASTERIXDB-3581][EXT]: Do not retry GCS SDK requests if thread is interrupted ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: Looking into the cancellation test File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/gcs/GCSConstants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/404b0d8f_a0724ada PS1, Line 83: if (Thread.currentThread().isInterrupted()) { : return false; : } > The root issue here is if the exception is an interrupt, not if the thread is > interrupted. […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/12342afa_d3b2339d PS1, Line 99: if (Thread.currentThread().isInterrupted()) { : return false; : } > The root issue here is if the exception is an interrupt, not if the thread is > interrupted. […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I5deb956bda11ee2ca41a1c05616788b2d697622f Gerrit-Change-Number: 19525 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 09:42:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]> Gerrit-MessageType: comment
