>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 )
Change subject: [ASTERIXDB-3581][EXT]: Do not retry GCS SDK requests if thread is interrupted ...................................................................... Patch Set 3: (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSCloudClient.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/47c88d0c_67d0afc5 PS3, Line 80: private final ExecutorService executor; we can probably delete this field if we no longer require an executor https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/9e1eac68_cef680ec PS3, Line 83: ExecutorService executor we can probably delete this parameter if we no longer require an executor File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/google/gcs/GCSParallelDownloader.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525/comment/2561686c_73f9dc70 PS3, Line 139: try { this causes us to leak clients if the transfer manager close fails- revert. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19525 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I5deb956bda11ee2ca41a1c05616788b2d697622f Gerrit-Change-Number: 19525 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 15:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
