Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1271: Revisit UUID Implementation ......................................................................
Patch Set 2: (1 comment) Looks good to me, just one comment on the use of exceptions. https://asterix-gerrit.ics.uci.edu/#/c/610/2/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java File asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java: Line 39: public void parseUUIDString(String tokenImage) throws AlgebricksException { I think that we should have all of these methods throw HyracksDataExceptions. This might be inconsistent with a few of the object/methods around here, but it's the right long-term choice, as AlgebricksExceptions should be compile-time exceptions and HyracksDataExceptions should be runtime exceptions. -- To view, visit https://asterix-gerrit.ics.uci.edu/610 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
