Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1271: Revisit UUID Implementation ......................................................................
Patch Set 2: (3 comments) answered comments https://asterix-gerrit.ics.uci.edu/#/c/610/2/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java File asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java: Line 39: public void parseUUIDString(String tokenImage) throws AlgebricksException { > I think that we should have all of these methods throw HyracksDataException Done Line 40: if (tokenImage.length() != 36) { > Replace 36 by a constant in AUUID. Something like Done Line 93: private static int transformHexCharToInt(byte val) throws AlgebricksException { > Can we replace this by something like this? While the code would be simpler, the performance would not be as good- Character.digit has support for unicode characters, not limited to ASCII. This should compile into a tableswitch, which will be one indirection to retrieve the values. -- To view, visit https://asterix-gerrit.ics.uci.edu/610 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
