Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1271: Revisit UUID Implementation ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/610/3/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java File asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java: Line 41: static final ThreadLocal<byte []> threadUnique = new ThreadLocal<byte []>() { I'm wondering if - instead of keeping ThreadLocal state - we could a) externalize the state and keep it within the the consumer (the Evaluator created in CreateUUIDDescriptor) or b) keep it inside the AMutableUUID object as we probably create exactly one of those for each evaluator (however in this case we should probably document this requirement for the use of this class). Does this make sense? What would be the disadvantages? -- To view, visit https://asterix-gerrit.ics.uci.edu/610 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
