abdullah alamoudi has posted comments on this change. Change subject: Cleanup Feed CodeBase ......................................................................
Patch Set 3: (15 comments) Move the hyracks part to a separate change. https://asterix-gerrit.ics.uci.edu/#/c/798/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IExceptionHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/IExceptionHandler.java: Line 25 put back https://asterix-gerrit.ics.uci.edu/#/c/798/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedRuntimeInputHandler.java: Line 126: try { synchronized consumer.cause() Line 205: synchronized (spiller) { make it a constant instead of number Line 265: notify(); should return; Line 319: private void consume(ByteBuffer frame) { change to return the cause instead of void Line 341: memoryManager.release(frame); put release in a local finally clause https://asterix-gerrit.ics.uci.edu/#/c/798/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/FrameHelper.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/FrameHelper.java: Line 40: outputFrame.array()[start + FrameConstants.META_DATA_FRAME_COUNT_OFFSET] = (byte) (numberOfMinFrame & 0xff); remove comment (even though comment is good) https://asterix-gerrit.ics.uci.edu/#/c/798/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksFrameMgrContext.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksFrameMgrContext.java: Line 39: * @param bytes Revert and submit a JIRA issue instead. You are allowed to keep white spaces Line 40: * WS Line 44: * WS and line too long Line 46: * WS https://asterix-gerrit.ics.uci.edu/#/c/798/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/resources/memory/FrameManager.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/resources/memory/FrameManager.java: Line 51: } revert https://asterix-gerrit.ics.uci.edu/#/c/798/3/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java: Line 64: public void appendMessage() { make private and make message a parameter Line 74: } catch (Throwable th) { remove try catch https://asterix-gerrit.ics.uci.edu/#/c/798/3/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/LocalityAwareMToNPartitioningConnectorDescriptor.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/LocalityAwareMToNPartitioningConnectorDescriptor.java: Line 56: * (org.apache.hyracks.api.context.IHyracksTaskContext, revert -- To view, visit https://asterix-gerrit.ics.uci.edu/798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I545bc4f8560564e4c868a80d27c77a4edd97a8b8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
