abdullah alamoudi has posted comments on this change. Change subject: Cleanup Feed CodeBase ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/798/3/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java: Line 47: dWriter.subscribe(collector); > only allocate on first subscriber Done Line 50: adapterRuntimeManager.start(); > only start on first Done Line 59: adapterRuntimeManager.stop(); > only stop and cleanup on the last one Done Line 63: public void endOfFeed() throws HyracksDataException { > remove Done Line 71: public void terminate() { > fix terminate not to call unsubscribe before stopping the manager Done -- To view, visit https://asterix-gerrit.ics.uci.edu/798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I545bc4f8560564e4c868a80d27c77a4edd97a8b8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
