Till Westmann has posted comments on this change. Change subject: Cleanup Feed CodeBase ......................................................................
Patch Set 4: (10 comments) https://asterix-gerrit.ics.uci.edu/#/c/798/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/ISubscribableRuntime.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/api/ISubscribableRuntime.java: Line 37: * @throws InterruptedException WS https://asterix-gerrit.ics.uci.edu/#/c/798/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FrameDistributor.java: Line 46: throw new HyracksDataException("faile feed data provider", rootFailureCause); typo? Line 75: throw new HyracksDataException("faile feed data provider"); typo Line 91: * Fix. What should be done?: WS Line 92: * 0. mark failure so no one can subscribe or unsubscribe. WS Line 94: * 2. when fail() is called, call fail on all subscribers WS Line 126: innerCollector.close(); s/close/fail/ https://asterix-gerrit.ics.uci.edu/#/c/798/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ConcurrentFramePool.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/ConcurrentFramePool.java: Line 141: return "FeedMemoryManager [" + nodeId + "]" + "(consumed:" + handedOut + "/" + budget + ")"; s/FeedMemoryManager/ConcurrentFramePool/ https://asterix-gerrit.ics.uci.edu/#/c/798/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java: Line 47: dWriter.subscribe(collector); address comments in this file https://asterix-gerrit.ics.uci.edu/#/c/798/4/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedMemoryManagerUnitTest.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/feed/test/FeedMemoryManagerUnitTest.java: Line 322: * Runnables used for unit tests WS -- To view, visit https://asterix-gerrit.ics.uci.edu/798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I545bc4f8560564e4c868a80d27c77a4edd97a8b8 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
