pgj commented on code in PR #5546:
URL: https://github.com/apache/couchdb/pull/5546#discussion_r2105377333
##########
src/dreyfus/src/clouseau_rpc.erl:
##########
@@ -316,3 +326,49 @@ rpc(Ref, Msg) ->
clouseau() ->
list_to_atom(config:get("dreyfus", "name", "[email protected]")).
+
+-type service() :: sup | main | analyzer | cleanup.
+-type liveness_status() :: alive | timeout.
+
+-spec clouseau_services(MajorVsn) -> [service()] when
+ MajorVsn :: binary() | null.
+clouseau_services(MajorVsn) ->
+ case MajorVsn of
Review Comment:
Should we have this case distinction given that both branches are the same
at the moment? I think it is fine to receive the major version as a parameter,
but I am not sure if that knowledge should be utilized now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
