pgj commented on code in PR #5546:
URL: https://github.com/apache/couchdb/pull/5546#discussion_r2105392487
##########
src/dreyfus/src/clouseau_rpc.erl:
##########
@@ -285,6 +287,14 @@ analyze(Analyzer, Text) ->
version() ->
rpc({main, clouseau()}, version).
+-spec clouseau_major_vsn() -> null | binary() | no_return().
+clouseau_major_vsn() ->
+ case version() of
+ {ok, <<Major, _/binary>>} -> <<Major>>;
+ {ok, null} -> null;
+ {'EXIT', noconnection} -> throw("Clouseau is not connected yet!")
Review Comment:
The word "yet" sounds a bit odd. It sounds like the reason for getting
`noconnection` is because we have not yet configured the connection to
Clouseau, while it might be happening because we have lost the connection to
Clouseau that we had in the past. Therefore it may make sense to lose the
"yet" here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
