nickva commented on code in PR #5885:
URL: https://github.com/apache/couchdb/pull/5885#discussion_r2794656662
##########
src/couch_quickjs/build_js.escript:
##########
@@ -74,7 +74,7 @@ compile_bytecode(Js, CBytecode) ->
Tmp = CBytecode ++ ".tmp",
{ok, Cwd} = file:get_cwd(),
CompileCmd = Cwd ++ "/quickjs/qjsc -c -N bytecode -o c_src/" ++ Tmp ++ "
priv/" ++ Js,
- os:cmd(CompileCmd),
+ os:cmd(CompileCmd, #{exception_on_failure => true}),
Review Comment:
This doesn't seem to work in 26 and 27, only 28.
It won't hurt to have in 26 and 27, it just won't do what the option says,
it gets silently ignored so it's not worse than before.
##########
mise.toml:
##########
@@ -0,0 +1,9 @@
+[env]
+NODE_ENV = 'production'
+
+[tools]
Review Comment:
Would this make it difficult to switch to other erlang versions? Not sure if
there is a priority mechanism in play where my global or shell set erlang would
take precedence over mise.toml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
