rnewson commented on code in PR #5885:
URL: https://github.com/apache/couchdb/pull/5885#discussion_r2794886032
##########
src/couch_quickjs/build_js.escript:
##########
@@ -74,7 +74,7 @@ compile_bytecode(Js, CBytecode) ->
Tmp = CBytecode ++ ".tmp",
{ok, Cwd} = file:get_cwd(),
CompileCmd = Cwd ++ "/quickjs/qjsc -c -N bytecode -o c_src/" ++ Tmp ++ "
priv/" ++ Js,
- os:cmd(CompileCmd),
+ os:cmd(CompileCmd, #{exception_on_failure => true}),
Review Comment:
context here is that it failed when I tried a vsc Dev Container. I had
compiled `qjsc` locally on my mac, then that binary was copied into the dev
container. The makefile considered it 'up to date' but it was obviously built
for macos and not linux, so executing got a 'bad exec format' result, which we
ignored and continued with the rest, which crashed with `{error, enoent}` as
the output file didn't exist and `fread` crashes if it doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
