rnewson commented on code in PR #5885:
URL: https://github.com/apache/couchdb/pull/5885#discussion_r2794825590
##########
src/couch_quickjs/build_js.escript:
##########
@@ -74,7 +74,7 @@ compile_bytecode(Js, CBytecode) ->
Tmp = CBytecode ++ ".tmp",
{ok, Cwd} = file:get_cwd(),
CompileCmd = Cwd ++ "/quickjs/qjsc -c -N bytecode -o c_src/" ++ Tmp ++ "
priv/" ++ Js,
- os:cmd(CompileCmd),
+ os:cmd(CompileCmd, #{exception_on_failure => true}),
Review Comment:
ah shame. I am using 26 and it didn't crash, so I guess it's silently
ignored. I see it was added in otp source some time ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
