wlgusqkr commented on PR #3364:
URL: https://github.com/apache/dubbo-go/pull/3364#issuecomment-4603592208
@Alanxtl Thanks for the guidance! I've updated the PR to follow this
direction.
I reverted the `GetProtocolWithError` / metadata import-hint change and
added a side-effect import of `protocol/dubbo` in `registry/servicediscovery`,
so application-level service discovery registers its internal metadata
transport dependency automatically.
I kept the code change minimal and did not add a test in this revision. I
considered adding an isolated import test under something like
`registry/servicediscovery/importtest`, because an in-package test under
`registry/servicediscovery` can be affected by existing tests that call
`extension.SetProtocol("dubbo", ...)` with a mock protocol.
Do you think adding that isolated import test is worthwhile here, or would
you prefer keeping this as the minimal side-effect import change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
