pivotal-jbarrett commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r860983778
##########
geode-dunit/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerTestUtil.java:
##########
@@ -508,6 +494,11 @@ public boolean waitWhileNotEnoughEvents(long sleepMs, int
eventCount, int eventT
return waitWhileNotEnoughEvents(sleepMs, eventCount,
getEvents(eventType));
}
+
+ /**
+ * This method is not implemented to test event count matches the
eventsToCheck.size() which is
+ * confusing. It will wait and return if it got something in the
eventsToCheck or not.
+ */
Review Comment:
I don't agree, I would rather have the hover over documentation with some
information than none. Though completing the information should not be that
hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
