DonalEvans commented on code in PR #7608:
URL: https://github.com/apache/geode/pull/7608#discussion_r861007234
##########
geode-dunit/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerTestUtil.java:
##########
@@ -508,6 +494,11 @@ public boolean waitWhileNotEnoughEvents(long sleepMs, int
eventCount, int eventT
return waitWhileNotEnoughEvents(sleepMs, eventCount,
getEvents(eventType));
}
+
+ /**
+ * This method is not implemented to test event count matches the
eventsToCheck.size() which is
+ * confusing. It will wait and return if it got something in the
eventsToCheck or not.
+ */
Review Comment:
I just have a bee in my bonnet about javadocs after the big clean-up I did
lately, I think. I saw so many places where there was stuff like
```
/**
* Constructs the object
* /
public SomeClass(int param1, int param2) {
...
```
that provided no value as a javadoc and caused the linter to throw warnings.
I think sometimes people just use javadoc comments because they're green in
IntelliJ and so stand out more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
