pivotal-jbarrett commented on code in PR #7608: URL: https://github.com/apache/geode/pull/7608#discussion_r860985874
########## geode-dunit/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheServerTestUtil.java: ########## @@ -170,20 +157,20 @@ public static void createCacheClient(Pool poolAttr, String regionName, Propertie PoolFactoryImpl pf = (PoolFactoryImpl) PoolManager.createFactory(); pf.init(poolAttr); PoolImpl p = (PoolImpl) pf.create("CacheServerTestUtil"); - AttributesFactory factory = new AttributesFactory(); + AttributesFactory<Object, Object> factory = new AttributesFactory<>(); factory.setScope(Scope.LOCAL); factory.setPoolName(p.getName()); if (addControlListener) { factory.addCacheListener(new ControlListener()); } - RegionAttributes attrs = factory.create(); + RegionAttributes<Object, Object> attrs = factory.create(); cache.createRegion(regionName, attrs); pool = p; } public static void unsetJavaSystemProperties(Properties javaSystemProperties) { if (javaSystemProperties != null && javaSystemProperties.size() > 0) { - Enumeration e = javaSystemProperties.propertyNames(); + Enumeration<?> e = javaSystemProperties.propertyNames(); while (e.hasMoreElements()) { String key = (String) e.nextElement(); Review Comment: No point in checking the size, the for range loop won't do anything if it is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org