raboof commented on code in PR #7905:
URL: https://github.com/apache/geode/pull/7905#discussion_r2282370302
##########
geode-core/src/test/java/org/apache/geode/internal/size/ObjectSizerJUnitTest.java:
##########
@@ -33,13 +34,23 @@ public void test() throws Exception {
assertEquals(roundup(OBJECT_SIZE), ObjectGraphSizer.size(new
TestObject3()));
assertEquals(roundup(OBJECT_SIZE * 2 + REFERENCE_SIZE),
ObjectGraphSizer.size(new TestObject3(), true));
- assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE),
ObjectGraphSizer.size(new TestObject4()));
- assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE) + roundup(OBJECT_SIZE +
4),
+ if (SystemUtils.isAzulJVM()) {
+ assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE + 8),
ObjectGraphSizer.size(new TestObject4()));
Review Comment:
but does it make sense to add it in the test? wouldn't it make more sense to
add it to `OBJECT_SIZE` or `REFERENCE_SIZE`? Or is there something in the
calculation that needs to be different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
