JinwooHwang-SAS commented on PR #7905: URL: https://github.com/apache/geode/pull/7905#issuecomment-3227636420
Thank you very much for the thoughtful feedback, @raboof. I fully agree that the assertion roundup(OBJECT_SIZE + REFERENCE_SIZE + 8) does not clearly communicate why this should be the expected value, and in hindsight it does not provide sufficient motivation for the Azul JVM scenario. I made an effort to investigate why Azul’s JVM behaves differently here, but unfortunately I have not been able to determine the underlying reason. Because of that, I must admit I am not entirely satisfied with the current solution, and I share your concern that it may not be the most appropriate long-term approach. Wrapping the assertions does indeed seem like a cleaner and less speculative direction, and I would be glad to revisit and refine this in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
