raboof commented on PR #7905:
URL: https://github.com/apache/geode/pull/7905#issuecomment-3227589208
Thanks ;).
I won't revert the change, but I still don't find
`assertEquals(roundup(OBJECT_SIZE + REFERENCE_SIZE + 8),
ObjectGraphSizer.size(new TestObject4()));` a meaningful assertion - it's clear
_that_ the size is `roundup(OBJECT_SIZE + REFERENCE_SIZE + 8)`, but it's not
clear _why_. Unless we can motivate why it really _should_ be
`roundup(OBJECT_SIZE + REFERENCE_SIZE + 8)` I think I'd have preferred to just
wrap the assertions that don't hold on Azul in a `if (!SystemUtils.isAzulJVM())
{` without making statements about the azul scenario. OK for now though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
