jdaugherty commented on code in PR #15409: URL: https://github.com/apache/grails-core/pull/15409#discussion_r2926106178
########## grails-core/src/main/groovy/org/apache/grails/core/plugins/GrailsPluginDiscovery.java: ########## @@ -0,0 +1,593 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.core.plugins; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashMap; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Set; + +import groovy.lang.GroovyClassLoader; +import org.codehaus.groovy.control.CompilationFailedException; +import org.codehaus.groovy.runtime.IOGroovyMethods; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.springframework.core.env.Environment; +import org.springframework.core.io.Resource; +import org.springframework.core.io.support.PathMatchingResourcePatternResolver; + +import grails.plugins.GrailsPluginSorter; +import grails.plugins.GrailsVersionUtils; +import grails.plugins.PluginFilter; +import grails.plugins.exceptions.PluginException; +import grails.util.Metadata; +import org.apache.grails.core.plugins.filters.PluginFilterRetriever; +import org.grails.core.io.CachingPathMatchingResourcePatternResolver; +import org.grails.io.support.GrailsResourceUtils; + +/** + * This class provides the canonical implementations of Grails Plugin Discovery. Review Comment: Not just the classpath; it's responsible for finding configured Grails Plugins. The problem is the existing framework has 2 code paths - one that dynamically injects plugins (I think this is really just for tests) and one for searching on the classpath. I can change this to: "This class is responsible for locating Grails Plugins that should be loaded." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
