jdaugherty commented on code in PR #15409:
URL: https://github.com/apache/grails-core/pull/15409#discussion_r2926177822


##########
grails-core/src/main/groovy/grails/boot/config/GrailsEnvironmentPostProcessor.java:
##########


Review Comment:
   The classes in this area have historically been java.  Looking through the 
commit history, there have been numerous performance problems in this area and 
conversion to java was one of the "fixes".  I did not want to introduce a new 
pattern as I was only trying to abstract the existing logic.  I think if we 
introduce a hard contract, we could change this with some significant 
refactoring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to