matrei opened a new pull request, #15582: URL: https://github.com/apache/grails-core/pull/15582
This pull request updates the documentation and code comments for the `formActionSubmit` tag to clarify the meaning and usage of its attributes, especially regarding the distinction between the DOM `id` and the `id` used in generated URLs. The changes make the attribute descriptions more precise and user-friendly, and introduce documentation for the new `disabled` attribute. Documentation improvements: * Clarified the description of the `value` attribute as the label shown on the submit button, and the `id` attribute as the DOM id of the rendered input element in both the user documentation (`formActionSubmit.adoc`) and GroovyDoc comments (`FormTagLib.groovy`). [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580) * Added documentation for the `disabled` attribute, explaining that it disables the button when true. [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580) * Clarified that the `url` attribute should be used to provide an `id` for the generated link, since the top-level `id` attribute is reserved for the DOM element. [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580) * Improved consistency and readability of attribute descriptions, including punctuation and terminology (e.g., "generated link" instead of "link"). [[1]](diffhunk://#diff-476e02bef89135e6b187a2b66413103a5ca66d331886810ff705bd758564b03cL64-R75) [[2]](diffhunk://#diff-2a773759962f91a6e2ca2afe88468e03650c35d5af0275a0fcc847c87d52474dL560-R580) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
