jamesfredley commented on PR #15611: URL: https://github.com/apache/grails-core/pull/15611#issuecomment-4353645165
## End-to-end verification complete To answer the obvious question (does this **actually** fix what the release manager hit?), I built the patched CLI and reproduced the exact failing scenario. **Setup** (mirrors the release-manager's environment): - Built `:grails-shell-cli:installDist` from this branch with `projectVersion=7.0.11` (temporary, reverted; not part of this commit) - `GRAILS_REPO_URL=https://repository.apache.org/content/groups/staging/` - Fresh `GRAILS_HOME` in a clean temp dir (no cached profiles, no `~/.m2` fallback, no `~/.grails/settings.yml`) - Ran `grails-shell-cli create-app testapp` (the same command path the wrapper-launched CLI runs) **Before this PR** (current published v7.0.11 / staging): ``` | Error Error occurred running Grails CLI: Could not find artifact org.apache.grails.profiles:web:jar: in grails-override-repo (https://repository.apache.org/content/groups/staging) ``` **After this PR**: ``` Grails repo url override detected, including repo: https://repository.apache.org/content/groups/staging/ Resolving dependencies.......... ..................... |Application created at ...\testapp ``` **Smoke test on the generated app**: `./gradlew assemble` -> `BUILD SUCCESSFUL` (8 tasks, ~90s). The generated `build.gradle` even auto-includes the staging repo in `buildscript.repositories` and the project `repositories` block, and pins `grailsVersion=7.0.11` in `gradle.properties`. So: the literal failure scenario is now passing, the generated app actually builds, and we have a regression spec guarding the code path going forward. Safe to drop the current 7.0.11 staging, merge this, cherry-pick to master if desired, and re-cut. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
