jdaugherty commented on code in PR #15611:
URL: https://github.com/apache/grails-core/pull/15611#discussion_r3168949027
##########
grails-bom/base/build.gradle:
##########
@@ -93,7 +93,7 @@ dependencies {
continue
}
- boolean publishedProject =
subproject.pluginManager.hasPlugin('org.apache.grails.gradle.grails-publish-profile')
||
subproject.pluginManager.hasPlugin('org.apache.grails.gradle.grails-publish')
+ boolean publishedProject =
subproject.pluginManager.hasPlugin('org.apache.grails.gradle.grails-publish-profile')
||
subproject.pluginManager.hasPlugin('org.apache.grails.gradle.grails-publish')
|| subproject.pluginManager.hasPlugin('org.apache.grails.gradle.grails-profile')
Review Comment:
This isn't correct, this is checking if it's a profile. This code is trying
to determine whathte published projects are so they can be include din the bom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
