jamesfredley commented on PR #15615: URL: https://github.com/apache/grails-core/pull/15615#issuecomment-4357405701
Pushed cf47e9fddd addressing review feedback: **1. Renamed the toggle** (per @jdaugherty) `skipMicronautTests` -> `skipMicronautProjects`. The flag excludes whole projects from the build graph, not tests, and the new name eliminates the naming overlap with test-related flags. Renamed in: - `settings.gradle` (variable + property name + comments) - `gradle.properties` (documentation comment) - `.github/workflows/groovy-joint-workflow.yml` (CLI flag + comment) - `grails-doc/build.gradle` (comment ref) **2. Tightened grails-doc cross-references** Architectural review surfaced that the default and Hibernate 5 BOM pages still emitted unconditional `link:Grails%20BOM%20Micronaut.html[...]` cross-links even when the Micronaut BOM page itself was intentionally not generated. Guarded both links with the same `grailsMicronautBom != null` check that gates the rest of the Micronaut BOM logic, so generated pages stay internally consistent under skip mode. **Verification (JDK 21 locally)** | Command | Result | |---|---| | `./gradlew projects -PskipMicronautProjects` | zero Micronaut projects in graph | | `./gradlew projects` | full Micronaut subgraph (no regression) | | `./gradlew :grails-doc:generateBomDocumentation -PskipMicronautProjects` | BUILD SUCCESSFUL, 2 pages, no dead links | | `./gradlew :grails-doc:generateBomDocumentation` | BUILD SUCCESSFUL, 3 pages, all cross-links intact | Net diff vs the previous push: +13/-10 across the same 4 files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
