jdaugherty commented on code in PR #15615:
URL: https://github.com/apache/grails-core/pull/15615#discussion_r3171688738
##########
settings.gradle:
##########
@@ -73,6 +73,20 @@ buildCache {
rootProject.name = 'grails.core.ROOT'
+// Presence-based toggle (matches project convention: skipFunctionalTests,
skipCodeStyle, etc.).
+// When -PskipMicronautTests is passed (regardless of value), the
Grails-Micronaut "island"
+// is excluded from the build graph entirely:
+// * grails-micronaut (Grails plugin that re-exports the Micronaut platform)
+// * grails-micronaut-bom (overrides Groovy/Spock to Groovy 5 / Spock
2.4-groovy-5.0)
+// * the five grails-test-examples that consume grails-micronaut-bom
+//
+// Used by .github/workflows/groovy-joint-workflow.yml so the joint Groovy 4
snapshot
+// build does not try to compile Spock specs against a Groovy-5-only Spock
artifact.
+// Consumers that reference :grails-micronaut-bom (e.g.
grails-doc:generateBomDocumentation)
+// must guard those references with findProject(':grails-micronaut-bom') !=
null.
+// See https://github.com/apache/grails-core/issues/15613.
+def skipMicronautTests =
providers.gradleProperty('skipMicronautTests').isPresent()
Review Comment:
We already have test slicing, and this isn't skipping tests. It's skipping
projects. We should rename this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
