jamesfredley commented on code in PR #15615:
URL: https://github.com/apache/grails-core/pull/15615#discussion_r3171753899
##########
settings.gradle:
##########
@@ -73,6 +73,20 @@ buildCache {
rootProject.name = 'grails.core.ROOT'
+// Presence-based toggle (matches project convention: skipFunctionalTests,
skipCodeStyle, etc.).
+// When -PskipMicronautTests is passed (regardless of value), the
Grails-Micronaut "island"
+// is excluded from the build graph entirely:
+// * grails-micronaut (Grails plugin that re-exports the Micronaut platform)
+// * grails-micronaut-bom (overrides Groovy/Spock to Groovy 5 / Spock
2.4-groovy-5.0)
+// * the five grails-test-examples that consume grails-micronaut-bom
+//
+// Used by .github/workflows/groovy-joint-workflow.yml so the joint Groovy 4
snapshot
+// build does not try to compile Spock specs against a Groovy-5-only Spock
artifact.
+// Consumers that reference :grails-micronaut-bom (e.g.
grails-doc:generateBomDocumentation)
+// must guard those references with findProject(':grails-micronaut-bom') !=
null.
+// See https://github.com/apache/grails-core/issues/15613.
+def skipMicronautTests =
providers.gradleProperty('skipMicronautTests').isPresent()
Review Comment:
Renamed in cf47e9fddd:
- `skipMicronautTests` -> `skipMicronautProjects` across `settings.gradle`,
`gradle.properties`, `.github/workflows/groovy-joint-workflow.yml`, and the
grails-doc comment.
- Name now reflects what the flag actually does (skip whole projects, not
tests) and removes the overlap with test-related flag naming.
While in there, I also guarded the two unconditional Micronaut BOM
cross-references in `grails-doc/build.gradle` (lines 193, 206) - per Oracle
architectural review, when the Micronaut BOM page is intentionally omitted
under the skip flag, the default and Hibernate 5 BOM pages should not link to
it. Verified locally with both flag states (`./gradlew
:grails-doc:generateBomDocumentation`):
| Flag state | Pages generated | Cross-links |
|---|---|---|
| no flag | Default, Hibernate 5, Micronaut | all 3 link to each other |
| `-PskipMicronautProjects` | Default, Hibernate 5 | only link to each other
(no dead Micronaut link) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
