jdaugherty commented on code in PR #15619:
URL: https://github.com/apache/grails-core/pull/15619#discussion_r3176806691
##########
RELEASE.md:
##########
@@ -132,13 +132,13 @@ To ensure checksums match the server & signatures match,
run the script `etc/bin
Example:
```bash
- ./etc/bin/verify-jar-artifacts.sh v7.0.0-M4 <grailsdownloadlocation>
+ ./etc/bin/verify-jar-artifacts.sh v8.0.0-M1 <grailsdownloadlocation>
```
### Manual Verification: Reproducible Jar Files
-After all jar files are verified to be signed by a valid Grails key, we need
to build a local copy to ensure the file was built with the right code base.
The `very-reproducible.sh` script handles this check, but if the bootstrap
needs to be manually bootstrapped, perform the following step:
+After all jar files are verified to be signed by a valid Grails key, we need
to build a local copy to ensure the file was built with the right code base.
The `verify-reproducible.sh` script handles this check, but if the bootstrap
needs to be manually bootstrapped, perform the following step from inside the
downloaded source distribution:
- gradle -p gradle-bootstrap
+ cd gradle-bootstrap && gradle
Review Comment:
Why are you changing this?
##########
RELEASE.md:
##########
@@ -34,8 +34,8 @@ During the staging step, we must create a source distribution
& stage any binary
1. Create a release in `grails-core`:
* Click "Draft a new release" here:
https://github.com/apache/grails-core/releases
* On the draft new release screen, we execute the following steps:
- * The tag will have the prefix 'v', so for our release it would be
'v7.0.0-M4'
- * The "Target" will be the branch we build out of (this case it's the
default, 7.0.x)
+ * The tag will have the prefix 'v', so for our release it would be
'v8.0.0-M1'
Review Comment:
Why even bother changing this? The point of this is to just give an example
release tag, not keep
it in sync with our version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
