Copilot commented on code in PR #15677:
URL: https://github.com/apache/grails-core/pull/15677#discussion_r3306869905
##########
.github/workflows/release.yml:
##########
@@ -203,6 +219,40 @@ jobs:
publishToSonatype
aggregateChecksums
aggregatePublishedArtifacts
+ -PskipMicronautProjects
+ - name: "☕️ Switch to JDK 25 for Micronaut publish"
+ # Micronaut 5 platform GA targets JVM 25 bytecode, so the island
+ # artifacts (grails-micronaut, grails-micronaut-bom) must be built and
+ # staged from a JDK 25 runner. This is a NEW reproducibility pin -
+ # keep $JAVA_VERSION_MICRONAUT synced with the secondary JDK in
+ # etc/bin/Dockerfile so verifiers can reproduce the resulting JARs.
+ uses: actions/setup-java@v4
+ with:
+ distribution: liberica
+ java-version: ${{ env.JAVA_VERSION_MICRONAUT }}
+ - name: "📤 Publish Grails-Micronaut to Staging Repository"
+ env:
+ NEXUS_PUBLISH_USERNAME: ${{ secrets.NEXUS_STAGE_DEPLOYER_USER }}
+ NEXUS_PUBLISH_PASSWORD: ${{ secrets.NEXUS_STAGE_DEPLOYER_PW }}
+ NEXUS_PUBLISH_URL: ${{ vars.STAGING_URL }}
+ NEXUS_PUBLISH_STAGING_PROFILE_ID: ${{ secrets.STAGING_PROFILE_ID }}
+ NEXUS_PUBLISH_DESCRIPTION: '${{ env.REPO_NAME }}:${{ env.VERSION }}'
+ SIGNING_KEY: ${{ secrets.GPG_KEY_ID }}
+ run: >
+ ./gradlew
+ -x initializeSonatypeStagingRepository
+ findSonatypeStagingRepository
+ :grails-micronaut:publishToSonatype
+ :grails-micronaut-bom:publishToSonatype
Review Comment:
The JDK 25 Micronaut publish step stages `grails-micronaut` and
`grails-micronaut-bom`, but it does not run `aggregateChecksums` /
`aggregatePublishedArtifacts` after those projects are present. Because the
earlier Grails Core aggregation is run with `-PskipMicronautProjects`,
`build/grails-core-checksums.txt` and `build/grails-core-artifacts.txt` will
not include the two Micronaut artifacts, so the final release `CHECKSUMS.txt` /
`PUBLISHED_ARTIFACTS.txt` uploaded below will be incomplete. Add the
aggregation tasks to this JDK 25 step (or otherwise append the Micronaut
outputs before combining).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
