bito-code-review[bot] commented on PR #15677:
URL: https://github.com/apache/grails-core/pull/15677#issuecomment-4548898424

   <!-- Bito Reply -->
   The PR diff shows that the `grails-micronaut` and `grails-micronaut-bom` 
projects are skipped in Java 21 jobs using the `-PskipMicronautProjects` flag. 
This flag is applied in multiple build jobs to avoid compiling JVM-25-specific 
Micronaut code on Java 21. However, the final release step does not include 
these projects in the checksum and artifact aggregation, leading to incomplete 
`CHECKSUMS.txt` and `PUBLISHED_ARTIFACTS.txt` files. To fix this, the 
aggregation tasks `aggregateChecksums` and `aggregatePublishedArtifacts` should 
be added to the JDK 25 step to ensure the Micronaut artifacts are included in 
the final release files.
   
   **.github/workflows/gradle.yml**
   ```
   build:
         name: "Build Grails-Core (Java ${{ matrix.java }}, indy=${{ 
matrix.indy }})"
         strategy:
           matrix:
             java: [21, 25]
             indy: [true, false]
         runs-on: ubuntu-latest
         steps:
           - name: "Checkout code"
             uses: actions/checkout@v2
           - name: "🔍 Setup TestLens"
             uses: testlens-app/setup-testlens@v1
           - name: "🔨 Build project"
             run: >
               ./gradlew build :grails-shell-cli:installDist groovydoc
               --continue
               --stacktrace
               -PonlyCoreTests
               -PskipCodeStyle
               ${{ matrix.java == 21 && '-PskipMicronautProjects' || '' }}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to