jamesfredley commented on PR #15677: URL: https://github.com/apache/grails-core/pull/15677#issuecomment-4569659148
### Local build now keys off the build JDK Pushed a change to `settings.gradle` so the Grails-Micronaut island is selected by whatever JDK runs the build, instead of having to remember a flag: - **`./gradlew build` on JDK 21 (the Grails 8 baseline) just works.** The island is auto-excluded because Micronaut 5 GA bytecode targets JVM 25 and a sub-25 JDK cannot resolve or compile it. No `-PskipMicronautProjects` needed anymore. - **`./gradlew build` on JDK 25+ also builds Micronaut locally.** When the build JDK is 25 or newer the island is auto-included, so the same command builds the full graph - no flag, no separate task list. Explicit flags still win over the detection: - `-PskipMicronautProjects` force-excludes the island on **any** JDK (this is what `groovy-joint-workflow.yml` uses - that exclusion is a Groovy-version reason, not a JDK reason, so it must hold even on JDK 25). - `-PincludeMicronautProjects` force-includes the island on a sub-25 JDK (escape hatch; it still won't compile there, but the tasks become addressable). - If both are passed, `-PskipMicronautProjects` wins. Because each CI job pins its JDK via `setup-java`, the now-redundant `matrix.java == 21 && -PskipMicronautProjects` conditionals and the unconditional JDK-21 skip flags were removed from `gradle.yml`, `release.yml`, and `release-publish-docs.yml` - the JDK the job runs on decides it. The explicit flag is kept only where it is not a JDK proxy: `groovy-joint-workflow.yml` (Groovy reason) and the standalone `etc/bin` verify scripts (their first pass must exclude the island regardless of the ambient default JDK). Verified on JDK 21 with `./gradlew projects`: island absent by default, present with `-PincludeMicronautProjects`, absent with both flags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
