jamesfredley commented on code in PR #15654:
URL: https://github.com/apache/grails-core/pull/15654#discussion_r3314872463
##########
grails-async/core/src/main/groovy/org/grails/async/transform/internal/DelegateAsyncTransformation.java:
##########
@@ -118,7 +119,7 @@ private void applyDelegateAsyncTransform(ClassNode
classNode, ClassNode targetAp
if (existingMethod == null) {
ClassNode promiseNode =
ClassHelper.make(Promise.class).getPlainNodeReference();
ClassNode originalReturnType = m.getReturnType();
- if
(!originalReturnType.getNameWithoutPackage().equals(VOID)) {
+ if
(!VOID.equals(originalReturnType.getNameWithoutPackage())) {
Review Comment:
Extracted to #15682 (PR-B) - this is the constant-on-left equality change
(`VOID.equals(name)` instead of `name.equals(VOID)`). Reverted from PR-A in
ba235da8f7. Keeping open until #15682 lands.
##########
grails-async/core/src/main/groovy/org/grails/async/transform/internal/DelegateAsyncTransformation.java:
##########
@@ -200,7 +201,7 @@ protected DelegateAsyncTransactionalMethodTransformer
lookupAsyncTransactionalMe
try {
Class<?> transformerClass =
getClass().getClassLoader().loadClass("org.grails.async.transform.internal.DefaultDelegateAsyncTransactionalMethodTransformer");
return (DelegateAsyncTransactionalMethodTransformer)
transformerClass.getDeclaredConstructor().newInstance();
- } catch (Throwable e) {
+ } catch (Exception ignored) {
Review Comment:
Extracted to #15682 (PR-B) - this is the `catch (Throwable e)` -> `catch
(Exception ignored)` change. Reverted from PR-A in ba235da8f7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
