jamesfredley commented on code in PR #15654: URL: https://github.com/apache/grails-core/pull/15654#discussion_r3314874787
########## grails-data-mongodb/core/src/test/groovy/org/apache/grails/data/mongo/core/MongoDatastoreSpec.groovy: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.grails.data.mongo.core + +import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec + +abstract class MongoDatastoreSpec extends GrailsDataTckSpec<GrailsDataMongoTckManager> { Review Comment: Extracted to #15685 (PR-E) - the MongoDatastoreSpec file itself was deleted from PR-A in ba235da8f7. Will land on 8.0.x via #15685 if the refactor is approved there. Keeping this thread open until #15685 is resolved. ########## grails-datamapping-tck/src/main/groovy/org/apache/grails/data/testing/tck/tests/DetachedCriteriaSpec.groovy: ########## @@ -20,19 +20,23 @@ package org.apache.grails.data.testing.tck.tests import grails.gorm.DetachedCriteria import grails.gorm.PagedResultList -import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec import org.apache.grails.data.testing.tck.domains.Person +import org.apache.grails.data.testing.tck.base.GrailsDataTckSpec class DetachedCriteriaSpec extends GrailsDataTckSpec { + void setupSpec() { + manager.addAllDomainClasses([Person]) + } + void 'Test the list method returns a PagedResultList with pagination arguments'() { given: 'A bunch of people' createPeople() when: 'A detached criteria instance is created and the list method used with the max parameter' def criteria = new DetachedCriteria(Person) criteria.with { - eq('lastName', 'Simpson') + eq 'lastName', 'Simpson' Review Comment: Extracted to a clean-up PR exactly as you requested: #15684 (PR-D: DetachedCriteriaSpec command-chain syntax). The parens hunk was reverted from PR-A in ba235da8f7. Keeping this thread open until #15684 is resolved. ########## grails-async/gpars/build.gradle: ########## @@ -27,6 +27,8 @@ plugins { id 'org.apache.grails.buildsrc.publish' id 'org.apache.grails.buildsrc.sbom' id 'org.apache.grails.gradle.grails-code-style' + id 'org.apache.grails.gradle.grails-code-analysis' + id 'org.apache.grails.gradle.grails-jacoco' Review Comment: Acknowledging - this one is still in PR-A. The two added plugin lines (`grails-code-analysis` and `grails-jacoco`) are part of the build/test infrastructure that @borinquenkid argued should stay on stage-hibernate7 so Step 2 (#15568) doesn't have to inherit the same scaffolding. If you'd prefer the analysis/jacoco adoption extracted to its own PR, I can do that. Leaving open for your call. ########## grails-data-hibernate5/core/src/test/groovy/grails/gorm/hibernate/mapping/HibernateMappingBuilderTests.groovy: ########## @@ -20,12 +20,8 @@ package grails.gorm.hibernate.mapping import org.grails.orm.hibernate.cfg.CompositeIdentity import org.grails.orm.hibernate.cfg.HibernateMappingBuilder - -/** - * Created by graemerocher on 01/02/2017. - */ - Review Comment: Acknowledging - this is the deleted `Created by graemerocher on 01/02/2017` comment + a small import reorder. It's tiny and extracting it feels disproportionate (we're already at 5 PRs for Step 1). Happy to pull it out if you'd prefer, otherwise leaving in PR-A. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
