jamesfredley commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3343849314
##########
grails-test-examples/mongodb/hibernate5/grails-app/controllers/functional/tests/AuthorController.groovy:
##########
@@ -35,8 +35,8 @@ class AuthorController {
*/
def bindParams = ['name']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/mongodb/hibernate5/grails-app/controllers/functional/tests/BookController.groovy:
##########
@@ -34,8 +34,8 @@ class BookController {
*/
def bindParams = ['title']
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
+ params.max = Math.min(params.int('max', 10), 100)
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/views-functional-tests/grails-app/controllers/functional/tests/ProductController.groovy:
##########
@@ -34,9 +34,8 @@ class ProductController extends RestfulController<Product> {
* @param max The maximum
* @return A list of resources
*/
- @Override
- def index(Integer max) {
- params.max = Math.min(max ?: 10, 100)
+ def index() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
grails-test-examples/views-functional-tests/grails-app/controllers/functional/tests/TeamController.groovy:
##########
@@ -38,11 +38,11 @@ class TeamController extends RestfulController {
respond Composite.findByTeamAndPlayer(Team.load(1), Player.load(2))
}
- def deep(Long id) {
- respond Team.get(id)
+ def deep() {
Review Comment:
Committed in 369d674597 (Revert manual controller-action parameter
workarounds).
##########
dependencies.gradle:
##########
@@ -222,7 +225,10 @@ ext {
'liquibase-hibernate.version': '4.27.0',
'liquibase.version' : '4.27.0',
'hibernate.version' : '5.6.15.Final',
- 'groovy.version' : '5.0.5',
+ // Keep aligned with bomDependencyVersions['groovy.version'];
the main bom now uses
Review Comment:
Committed in df4750c506 (Pin org.ow2.asm in the micronaut BOM instead of
per-app overrides).
##########
grails-test-examples/micronaut/build.gradle:
##########
@@ -27,6 +27,10 @@ plugins {
version = '0.1'
group = 'micronaut'
+// The Micronaut platform ships org.ow2.asm above what the
grails-micronaut-bom pins; allow the
+// intentional platform override so validateDependencyVersions passes
(apache/grails-core#15677).
+ext.allowedBomOverrides = ['org.ow2.asm:asm', 'org.ow2.asm:asm-util']
Review Comment:
Committed in df4750c506 (Pin org.ow2.asm in the micronaut BOM instead of
per-app overrides).
##########
grails-test-examples/plugins/micronaut-singleton/build.gradle:
##########
@@ -25,6 +25,10 @@ plugins {
version = '0.1-SNAPSHOT'
group = 'com.example.grails.plugins'
+// The Micronaut platform ships org.ow2.asm above what the
grails-micronaut-bom pins; allow the
Review Comment:
Committed in df4750c506 (Pin org.ow2.asm in the micronaut BOM instead of
per-app overrides).
##########
grails-views-gson/src/test/groovy/grails/plugin/json/view/JsonViewTemplateResolverSpec.groovy:
##########
@@ -64,6 +71,8 @@ class JsonViewTemplateResolverSpec extends Specification {
}
+ // Skip on Groovy 5+ - mocking final methods
(GrailsWebRequest.getRequest()) not supported without special configuration
+ @IgnoreIf({ instance.isGroovy5OrLater() })
Review Comment:
Committed in 9dd79859c9 (Re-enable JsonViewTemplateResolverSpec on Groovy 5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
