jdaugherty commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3348159851
##########
grails-core/src/main/groovy/org/grails/compiler/injection/GrailsASTUtils.java:
##########
@@ -1510,8 +1510,20 @@ public static void processVariableScopes(SourceUnit
source, ClassNode classNode,
VariableScopeVisitor scopeVisitor = new VariableScopeVisitor(source);
if (methodNode == null) {
scopeVisitor.visitClass(classNode);
+ return;
+ }
+ scopeVisitor.prepareVisit(classNode);
+ if (methodNode.getExceptions() == null) {
+ // Groovy 5's VariableScopeVisitor reads the method's exceptions
array without a null check, and AST
Review Comment:
@paulk-asert if we created those
methods with an empty list of exceptions, would this be fixed? If this is
an intentional design change shouldn't Groovy change the add method to enforce
the exceptions argument is non-null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
