jamesfredley commented on code in PR #15557:
URL: https://github.com/apache/grails-core/pull/15557#discussion_r3343851674
##########
grails-bootstrap/src/main/groovy/org/grails/config/NavigableMap.groovy:
##########
@@ -174,7 +170,14 @@ class NavigableMap implements Map<String, Object>,
Cloneable {
}
private static Object resolveConfigMapValue(Map map, Object... keys) {
- keys.inject(map) { acc, key -> acc instanceof Map ? acc[key] : null }
+ // Groovy 5: indexing a ConfigObject with a missing key inserts an
empty ConfigObject,
Review Comment:
Committed in caad5429a0 (Document Groovy 5 behaviour changes in the upgrade
guide).
##########
grails-test-suite-uber/src/test/groovy/grails/compiler/DomainClassWithInnerClassUsingStaticCompilationSpec.groovy:
##########
@@ -55,14 +55,14 @@ class SomeClass implements Validateable {
static boolean namedQueriesClosureCalled = false
static constraints = {
- constraintsClosureCalled = true
+ SomeClass.constraintsClosureCalled = true
Review Comment:
Committed in caad5429a0 (Document Groovy 5 behaviour changes in the upgrade
guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
