codeconsole commented on PR #15666: URL: https://github.com/apache/grails-core/pull/15666#issuecomment-5017361732
Replying to the CHANGES_REQUESTED review: done both. Retargeted the PR to 8.0.x, and moved stack-filterer initialization into GrailsBootstrapRegistryInitializer's bootstrap-phase close listener (the same point PluginDiscovery is promoted to a bean), so the configured filterer is active before the ApplicationContext refreshes and every app type is covered -- not just apps that wire a GrailsExceptionResolver bean. Replied inline on each of the specific threads with the details. Also picked up the outstanding integration-test ask and the two test-quality issues from the same review while I was in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
